Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the default export function to useClipboard #71

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Rename the default export function to useClipboard #71

merged 2 commits into from
Oct 10, 2022

Conversation

aljadan
Copy link
Contributor

@aljadan aljadan commented Oct 7, 2022 •
edited
Loading

It will be more clear to use the name useClipboard instead of useCopyClipboard because:

  1. It matches the examples and the name of the package
  2. when using the examples, the intellisense will suggest useCopyClipboard instead of useClipboard and it will be confusing, as you can see in the image below:
    Screen Shot 2022-10-07 at 2 25 13 AM

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 882e2b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-use-clipboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 882e2b5:

Sandbox Source
react-use-clipboard-example Configuration

@danoc danoc merged commit b51078d into danoc:master Oct 10, 2022
@danoc
Copy link
Owner

danoc commented Oct 10, 2022

Thank you! It has been released in the latest version.

@aljadan aljadan changed the title Rename the function Rename the default export function to useClipboard Oct 10, 2022
@aljadan aljadan changed the title Rename the default export function to useClipboard Rename the default export function to useClipboard Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljadan @danoc