Temp patch to remove multiple tool calls (#2720) #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements a temporary patch to remove multiple tool calls in the Answer class of the DAnswer system.
- Modifies
_raw_output_for_explicit_tool_calling_llmsmethod in/backend/danswer/llm/answering/answer.py - Removes passing of tool definitions to LLM stream, potentially limiting multi-tool functionality
- Change is described as a temporary fix, suggesting a more permanent solution may be implemented later
- May impact system's ability to use multiple tools in sequence for complex queries
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+319
to
+321
| # as of now, we don't support multiple tool calls in sequence, which is why | ||
| # we don't need to pass this in here | ||
| # tools=[tool.tool_definition() for tool in self.tools], |
There was a problem hiding this comment.
logic: Removing tool definitions may prevent multiple tool calls. Consider the implications on system functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^