Add options to set fonts #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I was writing this I would have had a single size for each font (serif, sans-serif, monospace), but I think your choices provide a bit more flexibility. |
|
I haven't tested everything in depth, but it should work. |
danth
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Looks like there is an issue with the Sway module:
error: A definition for option `home-manager.users.danth.wayland.windowManager.sway.config.fonts.size' is not of type `floating point number'. Definition values:
- In `/nix/store/d8dfhghz782by1524kg8jwhjqmmv4hp3-modules/sway/hm.nix': 10
|
I didn't know nix distinguished integers and floating points, I'll fix that. |
danth
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #35 and #59 , we need a way to specify font sizes. I think the best approach is to select a nomenclature of font sizes that could be reused by modules. Here I propose one such nomenclature to start discussions. Once the nomenclature is agreed upon, we can update the modules to use it.