Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add darwinModules #71

Merged
merged 1 commit into from
Mar 28, 2023
Merged

feat: add darwinModules #71

merged 1 commit into from
Mar 28, 2023

Conversation

lovesegfault
Copy link
Contributor

Fixes: #67

@dwarfmaster
Copy link
Contributor

LGTM. Maybe some code could be factorised with the NixOS module, but it is not in a part I expect to change often, so I think it would be fine to merge as-is.

Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I can't test it.

Could we mention this in the README?

@lovesegfault
Copy link
Contributor Author

@danth Added a note to the README.

I hope you don't mind my use of Markdown link anchors, felt like the best way to avoid duplicating the link targets.

Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danth danth enabled auto-merge (squash) March 28, 2023 15:02
@danth danth merged commit dd33836 into danth:master Mar 28, 2023
@lovesegfault lovesegfault deleted the darwin-module branch March 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with nix-darwin
3 participants