Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style tweaks #52

Merged
merged 5 commits into from
Apr 29, 2015
Merged

Style tweaks #52

merged 5 commits into from
Apr 29, 2015

Conversation

danvk
Copy link
Owner

@danvk danvk commented Apr 29, 2015

Fixes #37

  • Cleans up logo + tagline
  • Tightens popular images panel & separates it from about/social
  • Fixes some broken paths

I'm not quite sure what to do with the social links—the red background is a bit jarring, and they're more functional if they're on the left side of the page.

cc @mgiraldo

danvk added a commit that referenced this pull request Apr 29, 2015
@danvk danvk merged commit e3b49c4 into master Apr 29, 2015
@mgiraldo
Copy link
Collaborator

try #898989 instead of red

----- Original Message -----
From: "danvk/oldnyc"
To:"danvk/oldnyc"
Cc:"Mauricio Giraldo"
Sent:Wed, 29 Apr 2015 09:07:28 -0700
Subject:Re: [oldnyc] Style tweaks (#52)

Merged #52 [1]. 

—

Reply to this email directly or view it on GitHub [2].

Links:

[1] #52
[2] #52 (comment)

@danvk
Copy link
Owner Author

danvk commented Apr 29, 2015

I'm not sure why it needs to be so dark. What do you think of #E0C3C3?

screen shot 2015-04-29 at 3 20 20 pm

@danvk
Copy link
Owner Author

danvk commented Apr 29, 2015

#eee (same as the popular photos panel) also looks reasonable:

screen shot 2015-04-29 at 3 21 49 pm

@mgiraldo
Copy link
Collaborator

👍

----- Original Message -----
From: "danvk/oldnyc"
To:"danvk/oldnyc"
Cc:"Mauricio Giraldo"
Sent:Wed, 29 Apr 2015 12:22:32 -0700
Subject:Re: [oldnyc] Style tweaks (#52)

#eee (same as the popular photos panel) also looks reasonable: 

 [1] 

—

Reply to this email directly or view it on GitHub [2].

Links:

[1]
https://cloud.githubusercontent.com/assets/98301/7399376/83213e06-ee83-11e4-9ed7-c39665027cb3.png
[2] #52 (comment)

@danvk
Copy link
Owner Author

danvk commented Apr 29, 2015

👍 to the gray or light red? :)

@mgiraldo
Copy link
Collaborator

oh... didnt see the red one... i think gray...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tagline
2 participants