Fix restler.Request inheritance of EventEmitter for 0.10.x #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, had to use @patricklodder's version for now. |
|
Please pull this!! It is driving me crazy and I need this to be in the master so that NPM retrieves it when I execute the |
|
+1. This is a must. Using @patricklodder branch for now. |
|
+1. This fix has been around for ages now |
This fix is wrong#113 is the correct fix to this problem. Not only do you need to set up the prototype correctly, but you should always call the constructor of the superclass, as I do here! |
|
@eric-wieser You are right, I must have messed up a test on your pr because it passes now. closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed, as previously proposed by others, inheritance of
events.EventEmitterforrestler.Request, this time with as little code changes as possible. I verified thattest/all.jsnow passes against node0.6.19,0.8.23and0.10.4.