Fix zero size image (#1266)

Related to #1260
daohoangson · Jun 9, 2024 · 339c5a5 · 339c5a5 · github-actions · Jun 9, 2024
1 parent 8d413e8
commit 339c5a5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/core/lib/src/widgets/css_sizing.dart b/packages/core/lib/src/widgets/css_sizing.dart
@@ -314,9 +314,11 @@ class _RenderCssSizing extends RenderProxyBox {
     final sizeWidth = scopedChild.getDryLayout(tightWidth);
 
     final childAspectRatio = sizeWidth.width / sizeWidth.height;
+    final sizeHeightRatio = sizeHeight.width / sizeHeight.height;
     const epsilon = 0.01;
-    if ((childAspectRatio - sizeHeight.width / sizeHeight.height).abs() >
-        epsilon) {
+    if (childAspectRatio.isNaN ||
+        sizeHeightRatio.isNaN ||
+        (childAspectRatio - sizeHeightRatio).abs() > epsilon) {
       return null;
     }
 

diff --git a/packages/core/test/tag_img_test.dart b/packages/core/test/tag_img_test.dart
@@ -381,6 +381,16 @@ void main() {
   });
 
   group('error handing', () {
+    testWidgets('renders zero dimensions', (WidgetTester tester) async {
+      // https://github.com/daohoangson/flutter_widget_from_html/issues/1260
+      const html = '<img src="${helper.kDataUri}" width="0" height="0" />';
+      final explained = await helper.explain(tester, html);
+      expect(
+        explained,
+        contains('[CssSizing:height≥0.0,height=0.0,width≥0.0,width=0.0,child='),
+      );
+    });
+
     testWidgets('executes errorBuilder', (WidgetTester tester) async {
       const html = 'Foo <img src="data:image/jpg;base64,xxxx" /> bar';
       await tester.pumpWidget(