Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNTESTED] Changed the CO2ken scheme to process decimal values of input fields #1555

Merged
merged 3 commits into from
Apr 6, 2020

Conversation

raphabenoi
Copy link
Contributor

Altered the ProposalSummaryCO2ken.tsx to account for the changes in the
CO2ken.json scheme and correctly display decimal values.

Couldn't test it locally yet because it wouldn't compile properly due to unrelated issues:

ERROR in ./src/arc.ts
Module not found: Error: Can't resolve 'web3modal' in '/Users/raphaelbenoit/Documents/*BRAIN*/Projects/EthLondon/alchemy/src'
 @ ./src/arc.ts 17:20-40
 @ ./src/App.tsx
 @ ./src/index.tsx
 @ multi react-hot-loader/patch webpack-dev-server/client?http://127.0.0.1:3000 webpack/hot/only-dev-server ./src/index.tsx

ERROR in [at-loader] ./src/arc.ts:4:31 
    TS2307: Cannot find module 'web3modal/lib/helpers/types'.

ERROR in [at-loader] ./src/arc.ts:7:44 
    TS2307: Cannot find module 'web3modal'.

ERROR in [at-loader] ./src/arc.ts:398:80 
    TS2339: Property 'name' does not exist on type 'IWeb3ProviderInfo'.

ERROR in [at-loader] ./src/arc.ts:506:95 
    TS2339: Property 'name' does not exist on type 'IWeb3ProviderInfo'.

ERROR in [at-loader] ./src/actions/web3Actions.ts:42:51 
    TS2339: Property 'name' does not exist on type 'IWeb3ProviderInfo'.

ERROR in [at-loader] ./src/actions/web3Actions.ts:46:51 
    TS2339: Property 'name' does not exist on type 'IWeb3ProviderInfo'.

ERROR in [at-loader] ./src/layouts/Header.tsx:258:71 
    TS2339: Property 'name' does not exist on type 'IWeb3ProviderInfo'.

ERROR in [at-loader] ./src/layouts/Header.tsx:261:140 
    TS2339: Property 'name' does not exist on type 'IWeb3ProviderInfo'.

@raphabenoi
Copy link
Contributor Author

Travis ran successfully. Ready for review :)

@raphabenoi raphabenoi marked this pull request as ready for review April 1, 2020 15:13
@raphabenoi
Copy link
Contributor Author

Hey @orenyodfat,
would it be possible to get a review app to see if the decimal transformation works properly?

@tibetsprague tibetsprague temporarily deployed to alchemy-dev-lzzfahsjtdekflsabk April 1, 2020 18:51 Inactive
@tibetsprague
Copy link
Contributor

launching one now

@tibetsprague
Copy link
Contributor

@raphabenoi
Copy link
Contributor Author

raphabenoi commented Apr 1, 2020

@tibetsprague thanks!

Unfortunately, there seems to be a problem with the Graph protocol. So, new proposals are not shown on Rinkeby.

@orenyodfat wrote in the DAOStack Support Telegram channel:

we encounter some issues with our rinkeby subgraph in the last few days . 
it is currently out of sync and we are working with the graph team to solve it . 
we are working now to bring up alchemy staging on "kovan" as an alternative which will come very soon. 
once it will be up , lets try to deploy your dao on kovan.

But I can already make out an adjustment that needs to be made.

@orenyodfat orenyodfat closed this Apr 1, 2020
@orenyodfat orenyodfat reopened this Apr 1, 2020
@orenyodfat orenyodfat temporarily deployed to alchemy-dev-few76rwt9i0hluzpd8 April 1, 2020 20:37 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-dev-few76rwt9i0hluzpd8 April 1, 2020 20:59 Inactive
@orenyodfat
Copy link
Contributor

src/settings.ts Outdated Show resolved Hide resolved
Altered the ProposalSummaryCO2ken.tsx to account for the changes in the
CO2ken.json scheme and correctly display decimal values.
@orenyodfat orenyodfat temporarily deployed to alchemy-dev-few76rwt9i0hluzpd8 April 5, 2020 17:23 Inactive
@orenyodfat orenyodfat self-requested a review April 5, 2020 18:57
@orenyodfat orenyodfat merged commit 0cc5c22 into daostack:dev Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants