Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing #596.
The problem was that the mapping was from
proposalId => proposalInfo
. The reason that it cannot be part of the mapping which also contains the avatar, is that the result from the call from the voting machine does not contain the avatar.This can be utilized by a malicious voting machine to overwrite another proposal. Note that it is not enough just to check that the
proposalInfo
is empty as it will be easy to predict the next IDs (the hash is deterministic) and freeze the DAO.The solution is to have a mapping per voting machine, thus, if a DAO is working with a legit voting machine, its proposals are safe.