Fix AssertionErrors in close() of aio_pika client. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #91 shows an AssertionError when a connected aio_pika client which didn't need to open a result queue calls client.close(). It should be possible to call client.close() also in this case to close the connection to the RabbitMQ server, because when either the client was interrupted, had nothing to do before closing, it, this is the normal state. Also replace the other assertions in the aio_pika client's close() with simple checks which don't abort the function to close any other remaining connection elements or futures which are not properly handled when simply aborting with an assertion. For details and a test case, see issue #91.
bernhardkaindl
force-pushed
the
pika-close-without-assertions
branch
from
cd9c0a9
to
6003caf
Compare
Codecov Report
@@ Coverage Diff @@
## dev #92 +/- ##
==========================================
- Coverage 79.49% 79.44% -0.06%
==========================================
Files 41 40 -1
Lines 2717 2715 -2
==========================================
- Hits 2160 2157 -3
- Misses 557 558 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bernhardkaindl
changed the title
bernhardkaindl
changed the title
|
@dapper91 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #91 shows an AssertionError when a connected aio_pika client which didn't need to open a result queue calls client.close().
It should be possible to call client.close() also in this case to close the connection to the RabbitMQ server, because when either the client was interrupted, had nothing to do before closing, it, this is the normal state.
Also replace the other assertions in the aio_pika client's close() with simple checks which don't abort the function to close any other remaining connection elements or futures which are not properly handled when simply aborting with an assertion.
For details and a test case, see issue #91.