Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audit log #69

Merged
merged 1 commit into from
Dec 26, 2019
Merged

add audit log #69

merged 1 commit into from
Dec 26, 2019

Conversation

metabd
Copy link

@metabd metabd commented Dec 19, 2019

implement features #64 #65

@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #69 into develop will decrease coverage by 1.38%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
- Coverage    38.35%   36.96%   -1.39%     
===========================================
  Files          120      123       +3     
  Lines        10311    10847     +536     
===========================================
+ Hits          3955     4010      +55     
- Misses        5956     6430     +474     
- Partials       400      407       +7
Impacted Files Coverage Δ
gemmill/rpc/server/handlers.go 0% <0%> (ø)
gemmill/config/config.go 0% <0%> (ø) ⬆️
gemmill/blockchain/reactor.go 0% <0%> (ø) ⬆️
gemmill/p2p/pex_reactor.go 0% <0%> (ø) ⬆️
gemmill/modules/go-log/zap.go 12.69% <0%> (-3.47%) ⬇️
gemmill/p2p/peer.go 0% <0%> (ø) ⬆️
gemmill/rpc/server/http_server.go 59.82% <76.92%> (ø)
gemmill/blockchain/pool.go 63.9% <0%> (-4.52%) ⬇️
gemmill/rpc/server/http_params.go 0% <0%> (ø)
... and 1 more

@needkane
Copy link
Member

加下单元测试

@needkane
Copy link
Member

LGTM

add audit log and traceId

add log limit size

p2p audit log

seperate audit log; add audit log test
@needkane needkane merged commit 25491e2 into dappledger:develop Dec 26, 2019
@metabd metabd deleted the fix_nonce branch January 15, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants