Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding API Engine Link to package #33

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Adding API Engine Link to package #33

merged 2 commits into from
Jul 2, 2023

Conversation

alexgonmad
Copy link
Collaborator

Screenshot from 2023-04-19 14-10-08

@alexgonmad alexgonmad requested a review from a team as a code owner April 19, 2023 12:26
alexpeterson91
alexpeterson91 requested changes Jul 2, 2023
View reviewed changes
Copy link
Member

@alexpeterson91 alexpeterson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be api or endpoint, because this is the RPC endpoint not an RPC engine endpoint

dappnode_package.json Outdated Show resolved Hide resolved
@alexpeterson91 alexpeterson91 force-pushed the alexgonmad/addingAPIEngineLink branch from 5dddfd0 to 429a454 Compare July 2, 2023 04:21
@alexpeterson91 alexpeterson91 self-requested a review July 2, 2023 04:22
@alexpeterson91 alexpeterson91 merged commit 7d1837e into master Jul 2, 2023
@alexpeterson91 alexpeterson91 deleted the alexgonmad/addingAPIEngineLink branch July 2, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpeterson91 alexpeterson91 alexpeterson91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgonmad @alexpeterson91