-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git commit hash to version output #599
Comments
@rynowak I agree. This also needs a fix in dapr/dapr repo. |
Also consider adding the runtime api version to the output. |
/assign |
I think we need to treat this as a breaking change if we were to change the format of the dapr --version output. Users CI/CD pipelines may already be depending on the current output format. Perhaps if we were to add a |
Say I were a customer with a CI/CD script like this: VERSION=$(dapr --version | awk -F ': ' '/Runtime/ {print $2}')
echo $VERSION We can't have this change be breaking integrations like this, can we? |
Describe the proposal
We should add the git commit hash to the version output of both
dapr --version
anddaprd --version
As an example here's what
kubectl
does:We don't need to adopt JSON as a format - the takeaway here is that you can verify the supply chain of what you're using exactly. This is important for the team doing verification of a release - you can know what version you have exactly.
Release Note
RELEASE NOTE: ADDED git commit hash of cli and runtime to --version output
The text was updated successfully, but these errors were encountered: