Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'build-info' command #745

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Add 'build-info' command #745

merged 1 commit into from
Jun 24, 2021

Conversation

dmitsh
Copy link
Contributor

@dmitsh dmitsh commented Jun 23, 2021

Description

Add 'build-info' command

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #599

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@dmitsh dmitsh requested a review from artursouza June 24, 2021 16:46
yaron2
yaron2 previously approved these changes Jun 24, 2021
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaron2
Copy link
Member

yaron2 commented Jun 24, 2021

@dmitsh the tests are failing.

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #745 (c877025) into master (a81262a) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   19.69%   19.45%   -0.24%     
==========================================
  Files          28       28              
  Lines        1386     1403      +17     
==========================================
  Hits          273      273              
- Misses       1079     1096      +17     
  Partials       34       34              
Impacted Files Coverage Δ
pkg/standalone/version.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81262a...c877025. Read the comment docs.

@yaron2 yaron2 merged commit 67b9580 into dapr:master Jun 24, 2021
@dmitsh dmitsh deleted the ds-ver branch June 24, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add git commit hash to version output
3 participants