-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(httpendpoint): add tests for cli #1280
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Hey @mukundansundar! Does the runtime v1.11.0 release have to be cut before those would pass? I feel like this is almost a chicken before the egg scenario here... I saw the CRDs work off the raw data for the specific runtime version yaml files so I tried a work around pointing to master for the HTTPEndpoint yaml file, but then it tried to look for a "master" helm-chart release which does not exist. I also see TODO comments in |
This will depend on latest runtime changes and will need runtime RC at-least. |
Thank you @pravinpushkar!! I will circle back here then when the release is ready! |
@sicoyle dapr RC is out. Probably this PR can make use of that. |
I think 1284 needs to be merged before that. |
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
=======================================
Coverage 27.03% 27.03%
=======================================
Files 39 39
Lines 3873 3873
=======================================
Hits 1047 1047
Misses 2752 2752
Partials 74 74 |
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
E2E self hosted failure seems unrelated and due to timing out on installing podman:
also upload test results failure shows:
|
I think there may be a github issue or workflow connectivity issue going on for that last build because looking through the E2E upgrade path tests I see it's failing because of timing issues again: For example,
|
Signed-off-by: Samantha Coyle <sam@diagrid.io>
documenting again bc I've seen this issue inconsistently as well in my many e2e test failures 😅 The inconsistency part is definitely a timing related issue we should capture and address in the future; however, for the time being, this should have a conditional since the dapr dashboard is removed from the helm chart in v1.11 RC here. I am opening a PR to address separately.
|
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
* feat(httpenpoint): add tests for cli Signed-off-by: Samantha Coyle <sam@diagrid.io> * feat(httpendpoints): add httpendpoints in another place in tests Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(e2e): adjust checks for httpendpoints Signed-off-by: Samantha Coyle <sam@diagrid.io> * tests(e2e): more adjustments for httpendpoints Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(e2e): keep in mind dapr versions for tests Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(e2e): try workaround until 1.11 release Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(e2e): only test httpendpoints on new tests Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): check correct resource output Signed-off-by: Samantha Coyle <sam@diagrid.io> * style: make lint Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): only check httpendpoints if opt enabled Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): only check httpendpoints if opt enabled for uninstall Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(e2e): use latest rc Signed-off-by: Samantha Coyle <sam@diagrid.io> * style: make lint again Signed-off-by: Samantha Coyle <sam@diagrid.io> * test: try this Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(test): correct expected output string Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): master -> rc version Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): acct for ns already being deleted Signed-off-by: Samantha Coyle <sam@diagrid.io> * style: make linter happy Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): try a modification Signed-off-by: Samantha Coyle <sam@diagrid.io> * build: retrigger build with random comment update Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix(tests): rm extra test case Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix: address pr feedback Signed-off-by: Samantha Coyle <sam@diagrid.io> * fix: update based on pr feedback again Signed-off-by: Samantha Coyle <sam@diagrid.io> --------- Signed-off-by: Samantha Coyle <sam@diagrid.io> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Description
Add checks for new Dapr resource httpendpoints for external service invocation as per comment here.
Issue reference
dapr/dapr#6227
Please reference the issue this PR will close: #[4549]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: