Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dapr to stop multiple apps #355

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Conversation

chinzhiweiblank
Copy link
Contributor

@chinzhiweiblank chinzhiweiblank commented May 31, 2020

Description

I added the functionality of stopping multiple apps using dapr stop.

dapr stop pythonapp nodeapp blahblah

✅  app stopped successfully: pythonapp

✅  app stopped successfully: nodeapp

❌  failed to stop app id : couldn't find app id blahblah

This also works.

dapr stop pythonapp --app-id blahblah

✅  app stopped successfully: pythonapp

❌  failed to stop app id : couldn't find app id blahblah

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #247

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

I may need some advice on what tests and documentation to write for this functionality.

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@chinzhiweiblank chinzhiweiblank changed the title Add dapr stop multiple apps Enable Dapr to stop multiple apps May 31, 2020
cmd/stop.go Outdated Show resolved Hide resolved
@LMWF LMWF merged commit 51b99a9 into dapr:master Jun 2, 2020
@LMWF
Copy link
Contributor

LMWF commented Jun 2, 2020

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dapr stop should have a better error message
2 participants