Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI run should detect that either daprd or the app has exited and clean up #658

Merged
merged 5 commits into from
Apr 6, 2021

Conversation

wcs1only
Copy link
Contributor

@wcs1only wcs1only commented Apr 2, 2021

Description

On a dapr run, if either the daprd process or the app being run exits, dapr CLI will now detect that and exit.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #654

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #658 (fa01555) into master (ecfc611) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #658   +/-   ##
=======================================
  Coverage   20.14%   20.14%           
=======================================
  Files          28       28           
  Lines        1370     1370           
=======================================
  Hits          276      276           
  Misses       1061     1061           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfc611...fa01555. Read the comment docs.

@wcs1only wcs1only merged commit 786042d into dapr:master Apr 6, 2021
@wcs1only wcs1only added this to the v1.2 milestone Apr 6, 2021
@mukundansundar mukundansundar removed this from the v1.2 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Shutdown API kill CLI process
3 participants