Allow to specify port in placement-host-address #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 19.45% 19.63% +0.17%
==========================================
Files 28 28
Lines 1403 1406 +3
==========================================
+ Hits 273 276 +3
Misses 1096 1096
Partials 34 34
Continue to review full report at Codecov.
|
Closed
4 tasks
wcs1only
reviewed
Jun 24, 2021
artursouza
reviewed
Jun 24, 2021
artursouza
previously approved these changes
Jun 24, 2021
Co-authored-by: Charlie Stanley <charlie.stanley@microsoft.com>
artursouza
approved these changes
Jun 24, 2021
wcs1only
approved these changes
Jun 24, 2021
mukundansundar
approved these changes
Jun 28, 2021
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* Allow to specify port in placement-host-address * Update cmd/run.go Co-authored-by: Charlie Stanley <charlie.stanley@microsoft.com> Co-authored-by: Charlie Stanley <charlie.stanley@microsoft.com> Signed-off-by: Andy Le <anhldbk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to specify port in placement-host-address
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #705
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: