-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update amqp091-go to fix memory issues #2927
Update amqp091-go to fix memory issues #2927
Conversation
Thanks for this! https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work Can you please fix the DCO issue? |
Also, as you re-submit this, please also run |
ready |
DCO is still failing so I can't merge this sadly :( Please re-do this and when you make a commit, use the |
|
I should already |
It still appears as failing. You can see here: https://github.com/dapr/components-contrib/pull/2927/checks?check_run_id=14450199282 |
… consumption problems have been resolved. And break the package. Signed-off-by: arturo <jarturotrenard@gmail.com>
Signed-off-by: arturo <jarturotrenard@gmail.com>
Signed-off-by: arturo <ajt@ptytechnologies.com> Signed-off-by: arturo <jarturotrenard@gmail.com>
77be959
to
8ea9a36
Compare
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 8ea9a36 |
Components certification testCommit ref: 8ea9a36 ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 8ea9a36 ✅ All conformance tests passedAll tests have reported a successful status |
You need to run |
Signed-off-by: arturo <jarturotrenard@gmail.com>
By the way, the the replace directive you removed was actually used. This was an indirect dependency which was unlicensed, and therefore had to be force replaced with a licensed version. Otherwise our project cannot be released as Apache 2.0 |
… consumption problems have been resolved. And break the package.
Description
This update is important because from version v1.7.0 to v1.8.1 memory consumption problems have been resolved. And break the package.
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: