Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amqp091-go to fix memory issues #2927

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

arturotrenard
Copy link
Contributor

… consumption problems have been resolved. And break the package.

Description

This update is important because from version v1.7.0 to v1.8.1 memory consumption problems have been resolved. And break the package.

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@arturotrenard arturotrenard requested review from a team as code owners June 21, 2023 19:04
@ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle changed the title This update is important because from version v1.7.0 to v1.8.1 memory… Update amqp091-go to fix memory issues Jun 21, 2023
@ItalyPaleAle
Copy link
Contributor

Also, as you re-submit this, please also run make modtidy-all in the tree

@arturotrenard
Copy link
Contributor Author

Also, as you re-submit this, please also run make modtidy-all in the tree

ready

@ItalyPaleAle
Copy link
Contributor

Thanks for this! https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work

Can you please fix the DCO issue?

DCO is still failing so I can't merge this sadly :( Please re-do this and when you make a commit, use the -s flag. Such as git commit -s

@arturotrenard
Copy link
Contributor Author

Thanks for this! https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work
Can you please fix the DCO issue?

DCO is still failing so I can't merge this sadly :( Please re-do this and when you make a commit, use the -s flag. Such as git commit -s

@arturotrenard
Copy link
Contributor Author

Thanks for this! https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work
Can you please fix the DCO issue?

DCO is still failing so I can't merge this sadly :( Please re-do this and when you make a commit, use the -s flag. Such as git commit -s

I should already

@ItalyPaleAle
Copy link
Contributor

Thanks for this! https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work
Can you please fix the DCO issue?

DCO is still failing so I can't merge this sadly :( Please re-do this and when you make a commit, use the -s flag. Such as git commit -s

I should already

It still appears as failing. You can see here: https://github.com/dapr/components-contrib/pull/2927/checks?check_run_id=14450199282

arturo and others added 4 commits June 21, 2023 14:53
… consumption problems have been resolved. And break the package.

Signed-off-by: arturo <jarturotrenard@gmail.com>
Signed-off-by: arturo <jarturotrenard@gmail.com>
Signed-off-by: arturo <ajt@ptytechnologies.com>
Signed-off-by: arturo <jarturotrenard@gmail.com>
Signed-off-by: arturo <jarturotrenard@gmail.com>
@ItalyPaleAle
Copy link
Contributor

/ok-to-test

@dapr-bot
Copy link
Collaborator

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 8ea9a36

@dapr-bot
Copy link
Collaborator

dapr-bot commented Jun 21, 2023

Components certification test

🔗 Link to Action run

Commit ref: 8ea9a36

❌ Some certification tests failed

These tests failed:

  • pubsub.pulsar

@dapr-bot
Copy link
Collaborator

dapr-bot commented Jun 21, 2023

Components conformance test

🔗 Link to Action run

Commit ref: 8ea9a36

✅ All conformance tests passed

All tests have reported a successful status

@berndverst
Copy link
Member

You need to run make modtidy-all and commit all the modified go.sum and go.mod files.

Signed-off-by: arturo <jarturotrenard@gmail.com>
@ItalyPaleAle ItalyPaleAle added this pull request to the merge queue Jun 21, 2023
Merged via the queue into dapr:master with commit c066e99 Jun 21, 2023
@berndverst
Copy link
Member

By the way, the the replace directive you removed was actually used. This was an indirect dependency which was unlicensed, and therefore had to be force replaced with a licensed version. Otherwise our project cannot be released as Apache 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants