Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws sns metadata schema #3433

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

Eileen-Yu
Copy link
Contributor

@Eileen-Yu Eileen-Yu commented May 31, 2024

Description

Add metadata schema for aws sns binding.

Issue reference

#3432

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@Eileen-Yu Eileen-Yu requested review from a team as code owners May 31, 2024 18:11
Signed-off-by: Eileen Yu <eileenylj@gmail.com>
@Eileen-Yu Eileen-Yu force-pushed the feat/aws-sns-metadata-schema branch from b09158b to 3dfcd47 Compare May 31, 2024 18:15
yaron2
yaron2 previously approved these changes May 31, 2024
@yaron2 yaron2 dismissed their stale review May 31, 2024 18:31

Lint failing

@yaron2
Copy link
Member

yaron2 commented May 31, 2024

Thanks, please see failing lint

Signed-off-by: Eileen Yu <eileenylj@gmail.com>
@Eileen-Yu Eileen-Yu force-pushed the feat/aws-sns-metadata-schema branch from 914b002 to 1d1cfab Compare May 31, 2024 18:43
bindings/aws/sns/metadata.yaml Outdated Show resolved Hide resolved
@Eileen-Yu
Copy link
Contributor Author

added missing endpoint field, run make check-component-metadata and works fine locally... guess we may also want to add that field to docs here: https://docs.dapr.io/reference/components-reference/supported-bindings/sns/

Signed-off-by: Eileen Yu <eileenylj@gmail.com>
Signed-off-by: Eileen Yu <eileenylj@gmail.com>
@Eileen-Yu
Copy link
Contributor Author

guess this one is ready, the CI failure seems unrelated to this PR?

@berndverst berndverst merged commit b0bb3d7 into dapr:main Jun 4, 2024
87 of 91 checks passed
@berndverst berndverst added this to the v1.14 milestone Jun 4, 2024
@marcduiker
Copy link
Contributor

@holopin-bot @Eileen-Yu Enjoy the Dapr components badge!

Copy link

holopin-bot bot commented Jun 17, 2024

Congratulations @Eileen-Yu, you just earned a badge! Here it is: https://holopin.io/claim/clxj3wvr421770cjk1latgt4z

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants