Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'server' field to MongoDB metadata to support DNS SRV in connection URI #947

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Add 'server' field to MongoDB metadata to support DNS SRV in connection URI #947

merged 2 commits into from
Jun 16, 2021

Conversation

dmitsh
Copy link
Contributor

@dmitsh dmitsh commented Jun 16, 2021

Description

Added 'server' field to MongoDB metadata to support DNS seedlist connection format.
For non-empty server field, the connection URI is set to 'mongodb+srv:///'

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #904

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

…tion format.

*  for non-empty `server` field, the connection URI is set to 'mongodb+srv://<server>/'
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #947 (6f521ab) into master (d1b898b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage   35.45%   35.47%   +0.02%     
==========================================
  Files         135      135              
  Lines       10642    10646       +4     
==========================================
+ Hits         3773     3777       +4     
  Misses       6487     6487              
  Partials      382      382              
Impacted Files Coverage Δ
state/mongodb/mongodb.go 15.97% <100.00%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b898b...6f521ab. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr Mongo State Store component does not support srv record format
4 participants