Updating Secrets API endpoint #1084 #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add e2e test as well. |
We have a separate issue to track this, will be a separate PR. |
yaron2
requested changes
Feb 21, 2020
|
@cmendible is this still WIP? Are there any more commits you plan to push? |
cmendible
changed the title
It's complete. I just removed WIP from the title |
|
Reopened... I hit the wrong button on my phone... |
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-01. Please wait until test is done. |
|
End-to-end tests failed. |
|
Test failed because Docker Hub threw a 500 internal server error. Retrying. |
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-01. Please wait until test is done. |
|
Congrats! All end-to-end tests have passed. Thanks for your contribution! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating Secrets API endpoint as specified in #1084
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1084
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: