Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: add PKCS8 support #3241

Merged
merged 4 commits into from
Jun 10, 2021
Merged

sentry: add PKCS8 support #3241

merged 4 commits into from
Jun 10, 2021

Conversation

daixiang0
Copy link
Member

Signed-off-by: Long Dai long0dai@foxmail.com

Description

Add PKCS8 support.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3240

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@daixiang0 daixiang0 force-pushed the pkcs branch 3 times, most recently from 5238728 to 77df206 Compare June 1, 2021 05:55
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3241 (f15682c) into master (52eb8e4) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head f15682c differs from pull request most recent head a60be33. Consider uploading reports for the commit a60be33 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3241      +/-   ##
==========================================
+ Coverage   59.28%   59.31%   +0.02%     
==========================================
  Files          87       87              
  Lines        7796     7796              
==========================================
+ Hits         4622     4624       +2     
+ Misses       2857     2855       -2     
  Partials      317      317              
Impacted Files Coverage Δ
pkg/sentry/csr/csr.go 48.18% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52eb8e4...a60be33. Read the comment docs.

@daixiang0
Copy link
Member Author

@artursouza please help review

pkg/sentry/csr/csr.go Outdated Show resolved Hide resolved
pkg/sentry/csr/csr.go Outdated Show resolved Hide resolved
pkg/sentry/csr/csr.go Outdated Show resolved Hide resolved
pkg/sentry/csr/csr.go Outdated Show resolved Hide resolved
artursouza
artursouza previously approved these changes Jun 7, 2021
@artursouza artursouza added the automerge Allows DaprBot to automerge and update PR if all approvals are in place label Jun 7, 2021
Signed-off-by: Long Dai <long0dai@foxmail.com>
Signed-off-by: Long Dai <long0dai@foxmail.com>
Signed-off-by: Long Dai <long0dai@foxmail.com>
@dapr-bot dapr-bot merged commit 5a59a5a into dapr:master Jun 10, 2021
@daixiang0 daixiang0 deleted the pkcs branch June 10, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allows DaprBot to automerge and update PR if all approvals are in place
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PKCS#8 support
3 participants