-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: support unix domain socket #3529
Conversation
after build:
|
I'm really happy to see this PR landing. Notice tests are failing. |
e6c0ba3
to
5bc9518
Compare
Codecov Report
@@ Coverage Diff @@
## master #3529 +/- ##
==========================================
- Coverage 60.51% 60.37% -0.15%
==========================================
Files 97 97
Lines 8760 8784 +24
==========================================
+ Hits 5301 5303 +2
- Misses 3070 3092 +22
Partials 389 389
Continue to review full report at Codecov.
|
8d0d536
to
b3ff4e4
Compare
@yaron2 @artursouza not sure is it necessary for all e2e tests, so no e2e tests for now, please review codes first, thanks. |
7468b97
to
10998f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. This would need changes in the CLI, docs and SDKs too.
@artursouza I think CLI changes need to wait this merged if there is any e2e based on |
sorry for force push since flaky tests, if there is a better way to re-run tests, please tell me, thanks. |
Signed-off-by: Long <long0dai@foxmail.com>
@artursouza, should this be included in the 1.4 milestone? |
I prefer to add community contributions to the milestone when they get merged. |
Please, create tracking issues in CLI and SDKs. |
@yaron2 @greenie-msft @orizohar For this feature to be announced, we would need to have support in at least CLI and one SDK. |
Ok, but why? For example, cant users directly call via the socket if using their own gRPC client? |
Yes, but we should make it a first class feature with flags from CLI and config in the SDKs. Otherwise, people might not use it. |
Ok, just making sure there isn't some special config that needs to be done for this, and that regular gRPC/HTTP clients can use this. |
Signed-off-by: Long long0dai@foxmail.com
Description
Support unix domain socket.
Issue reference
Please reference the issue this PR will close: #2864
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: