Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSON secret store how to #609

Merged
merged 5 commits into from
Jun 2, 2020
Merged

Adding JSON secret store how to #609

merged 5 commits into from
Jun 2, 2020

Conversation

cmendible
Copy link
Member

Description

Adding JSON secret store how to

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #608

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@cmendible cmendible mentioned this pull request May 27, 2020
3 tasks
Copy link

@orizohar orizohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! this is a great doc. Please see my request for changes!

howto/setup-secret-store/json-secret-store.md Outdated Show resolved Hide resolved
howto/setup-secret-store/json-secret-store.md Outdated Show resolved Hide resolved
howto/setup-secret-store/json-secret-store.md Outdated Show resolved Hide resolved
howto/setup-secret-store/json-secret-store.md Outdated Show resolved Hide resolved
howto/setup-secret-store/json-secret-store.md Outdated Show resolved Hide resolved
orizohar
orizohar previously approved these changes May 28, 2020
@amanbha amanbha requested a review from orizohar June 2, 2020 18:13
@amanbha amanbha merged commit 8fff506 into dapr:master Jun 2, 2020
amanbha added a commit that referenced this pull request Jun 4, 2020
amanbha added a commit that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add local secret store how to
3 participants