Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Query all statenames from IActorStateManager because it does not behave as expected #53

Closed
amanbha opened this issue Sep 6, 2019 · 1 comment · Fixed by #536
Closed

Remove Query all statenames from IActorStateManager because it does not behave as expected #53

amanbha opened this issue Sep 6, 2019 · 1 comment · Fixed by #536
Assignees
@rynowak
Labels
area/actor/runtime breaking-change kind/enhancement New feature or request P2

Comments

@amanbha
Copy link
Contributor

amanbha commented Sep 6, 2019 •
edited
Loading

need support from runtime dapr/dapr#27
@msfussell msfussell mentioned this issue Sep 11, 2019
Closed
37 tasks
@amanbha amanbha changed the title Use Query all statenames api when implemented in Actions runtime. Use Query all statenames api when implemented in Dapr runtime. Oct 12, 2019
@amanbha amanbha added the P2 label Jul 21, 2020
@vinayada1 vinayada1 added the kind/enhancement New feature or request label Oct 27, 2020
@rynowak rynowak self-assigned this Jan 8, 2021
@rynowak
Copy link
Contributor

rynowak commented Jan 8, 2021

The features needed to implement this property were never added to the Dapr runtime. Since we can't really provide the right contract for this method, the best thing to do is to remove it to avoid confusion. We can revisit this based on feedback.

@rynowak rynowak changed the title Use Query all statenames api when implemented in Dapr runtime. Remove Query all statenames from IActorStateManager because it does not behave as expected Jan 8, 2021
rynowak added a commit that referenced this issue Jan 8, 2021
@rynowak
Remove GetAllStateNamesAsync
ba7f3fc 
Fixes: #53

This API was intended to query the state store for all existing state
entries for the actor. However support for this in the dapr runtime has
not be implemented. We're removing this API to avoid confusion since
it does not behave as expected. We can revisit this in the future based
on feedback.
@rynowak rynowak mentioned this issue Jan 8, 2021
Merged
3 tasks
rynowak added a commit that referenced this issue Jan 11, 2021
@rynowak
Remove GetAllStateNamesAsync (#536)
5e0b575 
Fixes: #53

This API was intended to query the state store for all existing state
entries for the actor. However support for this in the dapr runtime has
not be implemented. We're removing this API to avoid confusion since
it does not behave as expected. We can revisit this in the future based
on feedback.
vinayada1 pushed a commit that referenced this issue Jan 11, 2021
@rynowak @vinayada1
Remove GetAllStateNamesAsync (#536)
3bfd2e3 
Fixes: #53

This API was intended to query the state store for all existing state
entries for the actor. However support for this in the dapr runtime has
not be implemented. We're removing this API to avoid confusion since
it does not behave as expected. We can revisit this in the future based
on feedback.
vinayada1 pushed a commit that referenced this issue Jan 13, 2021
@rynowak @vinayada1
Remove GetAllStateNamesAsync (#536)
6bbf520 
Fixes: #53

This API was intended to query the state store for all existing state
entries for the actor. However support for this in the dapr runtime has
not be implemented. We're removing this API to avoid confusion since
it does not behave as expected. We can revisit this in the future based
on feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rynowak rynowak

Labels
area/actor/runtime breaking-change kind/enhancement New feature or request P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove GetAllStateNamesAsync dapr/dotnet-sdk
3 participants
@rynowak @amanbha @vinayada1