Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot should be run on the dapr-bot #523

Closed
mikeee opened this issue Mar 5, 2024 · 5 comments · Fixed by #531
Closed

Dependabot should be run on the dapr-bot #523

mikeee opened this issue Mar 5, 2024 · 5 comments · Fixed by #531
Assignees
@manojks1999
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mikeee
Copy link
Member

mikeee commented Mar 5, 2024

Dependabot should run on the dapr-bot go package at .github/workflows/dapr-bot https://github.com/dapr/go-sdk/blob/main/.github%2Fdependabot.yml
@mikeee mikeee added good first issue Good for newcomers enhancement New feature or request help wanted Extra attention is needed labels Mar 5, 2024
@manojks1999
Copy link
Contributor

Dependabot should run on the dapr-bot go package at .github/workflows/dapr-bot https://github.com/dapr/go-sdk/blob/main/.github%2Fdependabot.yml

Hi @mikeee ,
Can you explain briefly on this issue.

@mikeee
Copy link
Member Author

mikeee commented Mar 7, 2024 via email

@manojks1999
Copy link
Contributor

manojks1999 commented Mar 7, 2024 •
edited
Loading

Hey, the dependabot manifest should be updated so that the dapr-bot dependencies are kept up-to-date/managed by dependabot. The dependabot.yml manifest currently shows how the main go-sdk go.mod is kept up to date and should have a similar implementation. Let me know if you have any other questions! 🙂
…
On Thu, 7 Mar 2024, 04:41 manojks1999, @.> wrote: Dependabot should run on the dapr-bot go package at .github/workflows/dapr-bot https://github.com/dapr/go-sdk/blob/main/.github%2Fdependabot.yml Hi @mikeee https://github.com/mikeee , Can you explain briefly on this issue. — Reply to this email directly, view it on GitHub <#523 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWZQBXJNVYPZV47S5ED7ZLYW7VWTAVCNFSM6AAAAABEHPVQ3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGMZTKMJXHE . You are receiving this because you were mentioned.Message ID: @.>

Okay,
You mean we just need to update the configuration of the dependencies management YAML file to roughly like below.

version: 2
updates:
  - package-ecosystem: "gomod"
    directory: "/"
    schedule:
      interval: "daily"
  - package-ecosystem: "gomod"
    directory: "/.github/workflows/dapr-bot"
    schedule:
      interval: "daily"

and is it is also a daily cron ?

@mikeee
Copy link
Member Author

mikeee commented Mar 7, 2024 via email

@manojks1999 manojks1999 mentioned this issue Mar 7, 2024
Merged
@manojks1999
Copy link
Contributor

manojks1999 commented Mar 7, 2024 •
edited
Loading

Hi @mikeee ,

Created a PR pls have a look at it.

Thanks.

@mikeee mikeee linked a pull request May 16, 2024 that will close this issue
Dependabot added in workflow. #531
Merged
@mikeee mikeee closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manojks1999 manojks1999

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dependabot added in workflow. manojks1999/go-sdk
2 participants
@mikeee @manojks1999