Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the orphaned channel due to the GrpcChannelFacadeTest #1000

Merged

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Feb 5, 2024

Description

I've noticed several orphaned channels showing up locally and in CI. These orphaned channels muddy the error output when trying to debug other issues. I think this resolves one due to the GrpcChannelFacadeTest.

See 'passing' CI log here where there is an orphaned channel

I no longer see the orphaned channel due to this test file locally with this fix.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle requested review from a team as code owners February 5, 2024 00:27
@cicoyle cicoyle mentioned this pull request Feb 5, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (baef245) 77.56% compared to head (aa36e82) 77.56%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1000   +/-   ##
=========================================
  Coverage     77.56%   77.56%           
  Complexity     1568     1568           
=========================================
  Files           144      144           
  Lines          4757     4757           
  Branches        554      554           
=========================================
  Hits           3690     3690           
  Misses          781      781           
  Partials        286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit a5f0c41 into dapr:master Feb 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants