-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Kafka container wait time for HTTP bindings examples #1054
Increase Kafka container wait time for HTTP bindings examples #1054
Conversation
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
4514f69
to
4ce7412
Compare
@artursouza and @cicoyle after I have adjusted the sleep for Kafka container the Could you please take a look and let me know if you think it is OK to increase the |
Increasing the sleep usually highlights an issue, but it might be the case that for this test the initialisation is taking way much more time. I will defer to @artursouza and @cicoyle to validate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, in looking at the logs I see duration_seconds: 16.4
for this step: Setup kafka container
. I'm uncertain this fixes all the issues from this PR's autovalidate examples CI step, but we shall see
@salaboy I totally agree. I am not sure if |
The idea would be to have the sidecar to retry the init for some time before crashing. For this scope, timeout bump works. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
============================================
+ Coverage 76.91% 77.79% +0.88%
+ Complexity 1592 1570 -22
============================================
Files 145 144 -1
Lines 4843 4797 -46
Branches 562 563 +1
============================================
+ Hits 3725 3732 +7
+ Misses 821 780 -41
+ Partials 297 285 -12 ☔ View full report in Codecov by Sentry. |
@artursouza and @cicoyle it seems that everything is 👍. Could you please merge the PR? |
Description
Currently when running Java SDK examples for HTTP bindings it fails. It seems that using
sleep: 5
to wait for Kafka container to be up and running is not enough. The change is to increase the sleep value from5
to20
. This is not ideal, but it proved to work when running:on local box.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: