Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete DaprHTTPClient for actors. #1056

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

artursouza
Copy link
Member

Description

Left over from the HTTP client delete work: delete DaprHTTPClient for actors.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close:N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested review from a team as code owners June 22, 2024 02:21
@salaboy
Copy link
Contributor

salaboy commented Jun 24, 2024

LGTM, let's get this merged please :) @cicoyle can we approve this one ?

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks to be failing due to a compilation failure

@artursouza
Copy link
Member Author

CI looks to be failing due to a compilation failure

Fixed. Please, check the latest commit.

@artursouza artursouza merged commit d9cfba7 into dapr:master Jun 25, 2024
8 of 9 checks passed
@artursouza artursouza added this to the v1.12 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants