Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing data to Dapr Metadata and its components #1059

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

artur-ciocanu
Copy link
Contributor

Description

There were a couple of PRs related to getMetadata() method that has been added to DaprClient, but the DaprMetadata didn't contain all the details found here: https://docs.dapr.io/reference/api/metadata_api. This PR adds all the missing pieces

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1058

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu artur-ciocanu requested review from a team as code owners June 26, 2024 13:27
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu
Copy link
Contributor Author

@salaboy @artursouza and @cicoyle this PR adds a few of the missing fields from: https://docs.dapr.io/reference/api/metadata_api.

It might be a nitpick, but I have tried to order the fields and parameters as per docs, please let me know if this is not required.

Please take a look and let me know if this can be merged. Thank you!

@artursouza artursouza merged commit 64f291f into dapr:master Jun 26, 2024
10 checks passed
@artur-ciocanu artur-ciocanu deleted the complete-metadata-api branch June 26, 2024 20:19
@cicoyle cicoyle added this to the v1.12 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete the metadata API
3 participants