Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure messages to GRPC method invoke IT test #1077

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

artur-ciocanu
Copy link
Contributor

Description

This is another PR related to #1050 where we try to add more details to failing IT tests to see what is the underlying issue.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1076

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu
Copy link
Contributor Author

@artursouza @cicoyle @yaron2 could you please review and merge. It won't fix the IT test, but it should provide more meaningful test failure message.

Thank you.

@artursouza artursouza merged commit 5bf8769 into dapr:master Jul 12, 2024
9 checks passed
@cicoyle cicoyle added this to the v1.12 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more descriptive failure message for Service Invocation IT test
3 participants