Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotes to curl command #481

Merged
merged 2 commits into from
Oct 3, 2021
Merged

Add missing quotes to curl command #481

merged 2 commits into from
Oct 3, 2021

Conversation

jgardner04
Copy link
Contributor

Description

Updated documentation to correct the error in step 4.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

closes #480

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ x ] The quickstart code compiles correctly - no code was changed
  • [ x ] You've tested new builds of the quickstart if you changed quickstart code - documentation only change
  • [ x ] You've updated the quickstart's README if necessary

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good to me, including the updates to the formatting. The curl command is definately an issue in Powershell. Can you check that this curl command still works with a Linux bash terminal, so that there is a consistency (it should)

@jgardner04
Copy link
Contributor Author

@msfussell I have tested on Ubuntu (WSL2) and confirmed that they work.

@msfussell msfussell merged commit 38c3bcc into dapr:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello-Kubernetes bug in step 4
2 participants