Update DevContainer base image to fix CodeSpaces and DevContainer issues #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
dmitsh
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Make sure the client is actual built (#517) Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519) * Update base image to later Universal 1.x Focal, but still pin to 1.x major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> * Setting FLASK_RUN_PORT=5001 in distributed-calc Signed-off-by: Charlie Stanley <wistanle@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com>
dmitsh
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Make sure the client is actual built (#517) Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519) * Update base image to later Universal 1.x Focal, but still pin to 1.x major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> * Setting FLASK_RUN_PORT=5001 in distributed-calc Signed-off-by: Charlie Stanley <wistanle@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com>
dmitsh
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Make sure the client is actual built (#517) Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519) * Update base image to later Universal 1.x Focal, but still pin to 1.x major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> * Setting FLASK_RUN_PORT=5001 in distributed-calc Signed-off-by: Charlie Stanley <wistanle@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com>
msfussell
pushed a commit
that referenced
this pull request
Jan 25, 2022
* replace ports 5000/7000 with 5001/7001 to eliminate conflict with Control Center on MacOS (#521) Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com> * Sync master into release-1.6 (#523) * Make sure the client is actual built (#517) Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519) * Update base image to later Universal 1.x Focal, but still pin to 1.x major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> * Setting FLASK_RUN_PORT=5001 in distributed-calc Signed-off-by: Charlie Stanley <wistanle@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com> * update README (#524) Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com> Co-authored-by: Charlie Stanley <charlie.stanley@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com>
4 tasks
Arashrohani
pushed a commit
to Arashrohani/quickstarts
that referenced
this pull request
Feb 16, 2022
…ues (dapr#519) * Update base image to later Universal 1.x Focal, but still pin to 1.x major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Arashrohani
pushed a commit
to Arashrohani/quickstarts
that referenced
this pull request
Feb 16, 2022
* replace ports 5000/7000 with 5001/7001 to eliminate conflict with Control Center on MacOS (dapr#521) Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com> * Sync master into release-1.6 (dapr#523) * Make sure the client is actual built (dapr#517) Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Update DevContainer base image to fix CodeSpaces and DevContainer issues (dapr#519) * Update base image to later Universal 1.x Focal, but still pin to 1.x major version Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> * Setting FLASK_RUN_PORT=5001 in distributed-calc Signed-off-by: Charlie Stanley <wistanle@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com> * update README (dapr#524) Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com> Co-authored-by: Charlie Stanley <charlie.stanley@microsoft.com> Co-authored-by: Xavier Geerinck <xavier.geerinck@gmail.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Charlie Stanley <wistanle@microsoft.com> Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Yuknewicz paulyuk@microsoft.com
Description
Update DevContainer base image to fix CodeSpaces and DevContainer issues
The biggest issue is #518 causing Codespace to crash and go into recovery mode. To fix, we change the base image pin in Dockerfile from
universal:1.6.9-focaltouniversal:1-focalso we get updated 1.x semantic version but stop short of a possibly breaking 2.x release. The 1.6.9 focal image has the issue of running CodeSpaces out of storage during the Docker build (unpack) stages just on line 1 with the base image. the later 1-focal does not have this issue.This has the side effect of fixing #499 since Dapr can properly initialize
Also per #501 we clarify required SKU of GH to see CodeSpaces so more users are successful.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #518, #499, #501
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: