Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service invocation examples #536

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Added service invocation examples #536

merged 5 commits into from
Mar 4, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Feb 16, 2022

Signed-off-by: Amulya Varote amulyavarote@microsoft.com

Description

Added service invocation examples for dotnet, go, javascript and python

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #557

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@pravinpushkar
Copy link
Contributor

I think README.md files need to be adjusted according to suggestion given by @paulyuk

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things.

Also in the /go/* folders there are two binary files called app. Should we gitignore these?

service_invocation/csharp/http/README.md Outdated Show resolved Hide resolved
service_invocation/csharp/http/checkout/Program.cs Outdated Show resolved Hide resolved
service_invocation/go/http/README.md Outdated Show resolved Hide resolved
service_invocation/javascript/http/README.md Outdated Show resolved Hide resolved
service_invocation/python/http/README.md Outdated Show resolved Hide resolved
service_invocation/python/http/checkout/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor items left

service_invocation/javascript/http/checkout/package.json Outdated Show resolved Hide resolved
service_invocation/python/http/checkout/app.py Outdated Show resolved Hide resolved
service_invocation/python/http/checkout/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing feature add, thank you.

LGTM

@msfussell
Copy link
Member

@amulyavarote - Do you want to take a look at the failure above?

@amulyavarote
Copy link
Contributor Author

@amulyavarote - Do you want to take a look at the failure above?

yes. The PR builds are failing. We are looking into it

@tanvigour
Copy link
Contributor

#557

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @amulyavarote ! LGTM

@paulyuk
Copy link
Contributor

paulyuk commented Mar 4, 2022

The tests failures are flakiness on mac caused by some latencies and the same docker rate limiting we know about (fix in hand)

Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@msfussell msfussell merged commit cc8aa93 into dapr:feature/new_quickstarts Mar 4, 2022
@amulyavarote amulyavarote deleted the feature/service_invocation_examples branch March 4, 2022 17:44
@joebowbeer
Copy link
Contributor

One timing problem that occurred when I ran the javascript/http example in the devcontainer:

The order-processor may not be ready to receive the first order from the checkout service, in which case the first post returns a 500 and exits the checkout loop.

Moving the sleep to the top of the loop helps.

I think this problem and potential improvement applies to all of these service_invocation implementations.

Is there a better way for checkout to wait until the order-processor is running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants