-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added service invocation examples #536
Added service invocation examples #536
Conversation
I think README.md files need to be adjusted according to suggestion given by @paulyuk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things.
Also in the /go/* folders there are two binary files called app. Should we gitignore these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor items left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing feature add, thank you.
LGTM
@amulyavarote - Do you want to take a look at the failure above? |
yes. The PR builds are failing. We are looking into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @amulyavarote ! LGTM
The tests failures are flakiness on mac caused by some latencies and the same docker rate limiting we know about (fix in hand) |
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
One timing problem that occurred when I ran the javascript/http example in the devcontainer: The order-processor may not be ready to receive the first order from the checkout service, in which case the first post returns a 500 and exits the checkout loop. Moving the sleep to the top of the loop helps. I think this problem and potential improvement applies to all of these service_invocation implementations. Is there a better way for checkout to wait until the order-processor is running? |
Signed-off-by: Amulya Varote amulyavarote@microsoft.com
Description
Added service invocation examples for dotnet, go, javascript and python
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #557
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: