Don't marshal the order string #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
pushed a commit
to duglin/dapr-docs
that referenced
this pull request
Mar 22, 2022
Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com>
Don't marshal the order string because when we do we end up JSON-escaping things which looks funky and inconsistent with the other samples Signed-off-by: Doug Davis <dug@microsoft.com>
|
This change looks good to me. |
pkedy
approved these changes
Mar 23, 2022
|
My thought: This change makes sense also because |
paulyuk
approved these changes
Mar 23, 2022
duglin
pushed a commit
to duglin/dapr-docs
that referenced
this pull request
Mar 24, 2022
Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com>
duglin
pushed a commit
to duglin/dapr-docs
that referenced
this pull request
Apr 1, 2022
Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com>
duglin
pushed a commit
to duglin/dapr-docs
that referenced
this pull request
Apr 7, 2022
Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com>
duglin
pushed a commit
to duglin/dapr-docs
that referenced
this pull request
Apr 7, 2022
Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com>
msfussell
pushed a commit
to dapr/docs
that referenced
this pull request
Apr 7, 2022
* Minor tweaks to the service invocation quickstart Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com> * reorder pub-sub too Signed-off-by: Doug Davis <dug@microsoft.com> * add steps and uppercase Quickstart Signed-off-by: Doug Davis <dug@microsoft.com>
msfussell
added a commit
to dapr/docs
that referenced
this pull request
Apr 8, 2022
* Adding dotnet code snippet for saving and retrieving mulitple states (#2280) Signed-off-by: Will Velida <willvelida@microsoft.com> * Azure Key Vault RBAC role to get secrets updated (#2256) * Azure Key Vault RBAC role to get secrets updated Signed-off-by: Sergio Velmay <sergiovelmay@gmail.com> * Remove pin to localized version in MS link Signed-off-by: Sergio Velmay <sergiovelmay@gmail.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> * doc: fix typo premisis → premises (#2288) Signed-off-by: Andrea Spadaccini <andrea.spadaccini@gmail.com> * Remove dash in "dapr-init" (#2282) I'm guessing it's a typo because the md file has the dash. But the command itself doesn't Signed-off-by: Doug Davis <dug@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> * Minor updates to the golang pub-sub quickstart (#2283) Minor updates to the golang pub-sub quickstart - make the 'cd' command more clear by telling them to start from the clone - add the sample output from the publisher Signed-off-by: Doug Davis <dug@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> * Fix Redis Sentinel links Signed-off-by: Nick Greenfield <nigreenf@microsoft.com> * fix: Getting started / Init Dapr locally has wrong quickstarts link (#2287) * fix: Getting started / Init Dapr locally has wrong quickstarts link Signed-off-by: Yauri<me@yauri-io> Signed-off-by: y-io <me@yauri.one> * Change Next Steps to "Use the Dapr API" Signed-off-by: Nick Greenfield <nigreenf@microsoft.com> * Update install-dapr-selfhost.md Co-authored-by: y-io <me@yauri.one> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> * Fix typo * Update docs for hotfix Signed-off-by: Nick Greenfield <nigreenf@microsoft.com> * update shortcode to latest dapr version Signed-off-by: Nick Greenfield <nigreenf@microsoft.com> * doc: update arguments-annotations (#2306) Signed-off-by: Loong Dai <loong.dai@intel.com> * Fix typo: microservices Signed-off-by: Kyle Richelhoff <1271617+grepme@users.noreply.github.com> * Add mandatory `dapr init` step to Self-Hosted Mode in Container Docs (#2303) I followed the docs to ship Dapr together with an app inside the same container and came across the issue that `daprd` in the `ENTRYPOINT` was not available until i initialized dapr in slim mode. Signed-off-by: Robin-Manuel Thiel <robin-manuel@thiel1.de> Co-authored-by: Mark Fussell <markfussell@gmail.com> * capitalize 'quickstart'; add comma Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * typo fix; quick grammar pass (#2316) Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * typo fixes and quick grammar pass (#2317) Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> * adding Read buffer size argument to fasthttp server and grpc server (#2263) * adding Read buffer size argument to fasthttp server and grpc server dapr/dapr#3346 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. This is my commit message Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * added introduction to dapr-http-read-buffer-size Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Modify the note description Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Adding read buffer size argument to fasthttp server and grpc server Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Added introduction to dapr-http-read-buffer-size Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Modify the note description Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Modify this description Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Add a detailed description Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Make the appropriate title changes Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> * Modification introduction and corresponding instructions Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> * fix typo in command for python and js Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * remove info; clarify in other doc Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * link to state store spec; grammar pass Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * update per Mark Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * Add link to the dev docs I may have missed it but I couldn't find a way to go from the main README (https://github.com/dapr/dapr) to the dev docs. Signed-off-by: Doug Davis <dug@microsoft.com> * [quickstarts] Make code snippets consistent; link to repo (#2340) * link to repo; edit code snippet Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * remove first person; capitalize Quickstarts Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * capitalize quickstarts Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * remove first person Signed-off-by: Hannah Hunter <hannahunter@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> * Minor tweaks to the service invocation quickstart (#2284) * Minor tweaks to the service invocation quickstart Minor tweaks to the service invocation quickstart - run the consumer before the sender, otherwise things will fail - be clear about where to run the 'cd' cmd from - in the golang sender sample code I removed the extra "if" statement because it wasn't relevant to the point being made... adding a header - remove quotes from sender's json output to go along with dapr/quickstarts#621 Signed-off-by: Doug Davis <dug@microsoft.com> * reorder pub-sub too Signed-off-by: Doug Davis <dug@microsoft.com> * add steps and uppercase Quickstart Signed-off-by: Doug Davis <dug@microsoft.com> * Add state management quickstart (#2320) * Add state management quickstart * Address feedback on state-management quickstart * Add link to sample GitHub repo Signed-off-by: Nir Mashkowski <nimashkowski@microsoft.com> * Add changes from the Python section to the rest of the languages for consistency. Signed-off-by: Nir Mashkowski <nimashkowski@microsoft.com> * Update state management image, capitlize Quickstart and add client initiation code to Javascript, go, Python and C#. Signed-off-by: Nir Mashkowski <nimashkowski@microsoft.com> * Update statemanagement-quickstart.md Updated the overview paragraph * Update daprdocs/content/en/getting-started/quickstarts/_index.md * Update daprdocs/content/en/getting-started/quickstarts/_index.md * Update daprdocs/content/en/getting-started/quickstarts/_index.md Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> * Wrap docker desktop links in ignore Signed-off-by: Nick Greenfield <nigreenf@microsoft.com> Co-authored-by: Will Velida <willvelida@hotmail.co.uk> Co-authored-by: SergioVelmay <42042494+SergioVelmay@users.noreply.github.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> Co-authored-by: Andrea Spadaccini <andrea.spadaccini@gmail.com> Co-authored-by: Doug Davis <duglin@users.noreply.github.com> Co-authored-by: yauri-io <30032724+yauri-io@users.noreply.github.com> Co-authored-by: y-io <me@yauri.one> Co-authored-by: HMZ <hamzi1995@gmail.com> Co-authored-by: Looong Dai <loong.dai@intel.com> Co-authored-by: Kyle Richelhoff <1271617+grepme@users.noreply.github.com> Co-authored-by: Robin-Manuel Thiel <robin-manuel@thiel1.de> Co-authored-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Co-authored-by: loopFY <34152277+767829413@users.noreply.github.com> Co-authored-by: Doug Davis <dug@microsoft.com> Co-authored-by: nirmash <1372862+nirmash@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't marshal the order string because when we do we end up JSON-escaping
things which looks funky and inconsistent with the other samples
Signed-off-by: Doug Davis dug@microsoft.com