-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dotnet TargetFramework from v7.0 to v8.0 #960
Conversation
Signed-off-by: Phillip Ngan <phillip.ngan@gmail.com>
310b66b
to
41ffb9b
Compare
Hi Could someone double check this pull request. Currently DCO has failed, but I updated the commit message to have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for this!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I think more about it, may I ask for a few quick changes that make this work from end to end?
- Add .NET 8 as a second version to the validate csharp workflow here:
7.0.x
8.0.x
https://github.com/dapr/quickstarts/blob/release-1.13/.github/workflows/validate_csharp_quicstarts.yaml#L82
2) omit all files in http/batch/Debug/net6.0
3) make the change for Workflow quickstarts too
4) change this PR to baseline against the release-1.13
branch instead of master
so we keep this aligned with this latest release.
I'm happy to help with any of this, but most of these changes have to start from your side or the files will not be included in the PR. thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please exclude this from the PR, and double check your gitignore on all /Debug or /bin folders
Fixes #980 |
This pull request is superseded by pr 980. |
Description
Updated all the csproj files to use dotnet v8.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: