Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dotnet TargetFramework from v7.0 to v8.0 #960

Closed
wants to merge 1 commit into from

Conversation

pngan
Copy link
Contributor

@pngan pngan commented Dec 27, 2023

Description

Updated all the csproj files to use dotnet v8.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ x] The quickstart code compiles correctly
  • [ x] You've tested new builds of the quickstart if you changed quickstart code
  • [x ] You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Phillip Ngan <phillip.ngan@gmail.com>
@pngan
Copy link
Contributor Author

pngan commented Dec 28, 2023

Hi Could someone double check this pull request. Currently DCO has failed, but I updated the commit message to have a Signed-off-by: section, and put myself as the sign off person. Could someone fix this for me, if I have done something wrong. Thanks.

@paulyuk paulyuk self-requested a review February 11, 2024 20:33
@paulyuk paulyuk added this to the 1.13 milestone Feb 11, 2024
@paulyuk paulyuk self-assigned this Feb 11, 2024
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this!!

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think more about it, may I ask for a few quick changes that make this work from end to end?

  1. Add .NET 8 as a second version to the validate csharp workflow here:
            7.0.x
            8.0.x

https://github.com/dapr/quickstarts/blob/release-1.13/.github/workflows/validate_csharp_quicstarts.yaml#L82
2) omit all files in http/batch/Debug/net6.0
3) make the change for Workflow quickstarts too
4) change this PR to baseline against the release-1.13 branch instead of master so we keep this aligned with this latest release.

I'm happy to help with any of this, but most of these changes have to start from your side or the files will not be included in the PR. thank you!

@paulyuk paulyuk assigned pngan and unassigned paulyuk Feb 11, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this from the PR, and double check your gitignore on all /Debug or /bin folders

@paulyuk
Copy link
Contributor

paulyuk commented Feb 11, 2024

Fixes #980

@pngan pngan mentioned this pull request Feb 14, 2024
4 tasks
@pngan
Copy link
Contributor Author

pngan commented Feb 14, 2024

This pull request is superseded by pr 980.

@pngan pngan closed this Feb 14, 2024
@pngan pngan deleted the ChangeTargetFrameworkTo8 branch February 14, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants