-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #963
Update README.md #963
Conversation
Fix typos, problematic symbols and format, and some adjusting Signed-off-by: Farshad Davoudi <f.davoudi.r@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see one suggested tweak.
Also is there any change you could target this PR at the release-1.13 branch instead of master?
Signed-off-by: Farshad Davoudi <f.davoudi.r@outlook.com>
Hi @farshaddavoudi - something is wrong with the state management quickstart, so it won't pass checks anymore. what i usually do is cd into that quickstart folder and do a |
Hi @paulyuk |
Hi @farshaddavoudi sorry i did not include details about this. To do the local test you need Mechanical Marchdown which is a small utility found here: https://github.com/dapr/mechanical-markdown To install you just do this: Then that command should work well in each quickstart folder that has a makefile. |
Making some tweaks to STEPs so project can build and tests pass. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
--> | ||
|
||
```bash | ||
dotnet restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test was failing because the dotnet build
was not happening in order-processor subfolder. You could either set the working directory or cd into it.
However your simplification of restore and build made me think we should just further simplify. Dotnet language tools do a restore and build on run. So let's go straight to the run, which is done as a part of dapr run -f .
.
@@ -70,6 +58,7 @@ sleep: 15 | |||
cd ./order-processor | |||
dapr run --app-id order-processor --resources-path ../../../resources/ -- dotnet run | |||
``` | |||
<!-- END_STEP --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This end step was missing, which was problematic for test framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paulyuk, I apologize for not being able to participate and complete the job. I was busy preparing for my Azure certification exam. Thank you for approving my work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix typos, problematic symbols and format, and some adjusting
Description
Please explain the changes you've made
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: