Update proto files for 0.8.0 #16
Conversation
|
@youngbupark I updated the proto files according to dapr/proto. Can you verify if those two are the only proto files (dapr.proto and common.proto) that need to be updated for this milestone? Thanks |
Yes, we need to update only two files in this milestone. |
src/error.rs
Outdated
| @@ -24,13 +24,13 @@ impl From<TonicError> for Error { | |||
|
|
|||
| impl From<TonicStatus> for Error { | |||
| fn from(_error: TonicStatus) -> Self { | |||
| Error::GrpcError(GrpcError { status: _error }) | |||
| Error::GrpcError(GrpcError { error: _error }) | |||
There was a problem hiding this comment.
do you have the reason to rename from status to error? status makes more sense to me if it includes gRPC status code and its details.
There was a problem hiding this comment.
You are right, status makes more sense. I changed to error because of the struct name GrpcError. I'll revert it to status. Thanks
|
Thanks for your contribution! |
* fixed clippy warnings, moved imports to top * WIP: update proto files for 0.8.0, updating client in progress, * update client code for new proto * Update client example, README, added code comments * revert error to status
Description
Updating proto files (runtime/v1/dapr.proto and common/v1/common.proto) for 0.8.0 release.
Issue reference
This PR will fix #15 upon successful merge.
Checklist