Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pub sub example #20

Merged
merged 9 commits into from
Jul 14, 2020
Merged

Added pub sub example #20

merged 9 commits into from
Jul 14, 2020

Conversation

gdhuper
Copy link
Member

@gdhuper gdhuper commented Jul 5, 2020 •
edited
Loading

Description

Add support for appcallback and pub-sub example.

Issue reference

This PR will close: #17

Checklist

  • Add appcallback.proto
  • Code compiles correctly
  • Implement AppCallback server for subscription
  • Create Publish sample
  • Add/update documentation
  • Add convenient layer for AppCallbackServer
  • Fix clippy/lint warnings
  • End-to-end tests passing

@gdhuper gdhuper changed the title Added pub sub example WIP: Added pub sub example Jul 5, 2020
rylev
rylev reviewed Jul 5, 2020
View reviewed changes
examples/pubsub/publisher.rs Outdated Show resolved Hide resolved
src/appcallback.rs Outdated Show resolved Hide resolved
rylev
rylev reviewed Jul 6, 2020
View reviewed changes
examples/pubsub/publisher.rs Outdated Show resolved Hide resolved
rylev
rylev reviewed Jul 6, 2020
View reviewed changes
examples/pubsub/publisher.rs Outdated Show resolved Hide resolved
rylev
rylev reviewed Jul 6, 2020
View reviewed changes
examples/pubsub/publisher.rs Outdated Show resolved Hide resolved
@gdhuper gdhuper marked this pull request as ready for review July 7, 2020 08:05
@gdhuper gdhuper changed the title WIP: Added pub sub example Added pub sub example Jul 7, 2020
@gdhuper
Copy link
Member Author

gdhuper commented Jul 7, 2020

@rylev Thank you for your comments.

For appcallback, I was trying to do something similar to client.rs where the trait DaprInterface provides a convenient abstraction on top of DaprClient trait (generated from proto). However, in this case since an application is responsible for providing server implementation as opposed to just allowing pass through to API calls, I am not sure how to approach this. Do you have any pointers on how to go about this?

rylev
rylev reviewed Jul 7, 2020
View reviewed changes
examples/pubsub/publisher.rs Outdated Show resolved Hide resolved
@gdhuper
Copy link
Member Author

gdhuper commented Jul 8, 2020

@youngbupark This PR is ready to be reviewed. Thanks

youngbupark
youngbupark approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@youngbupark youngbupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! :)

@youngbupark youngbupark merged commit ef8ca51 into dapr:master Jul 14, 2020
@gdhuper gdhuper mentioned this pull request Nov 30, 2020
Closed
4 tasks
cscetbon pushed a commit to cscetbon/rust-sdk that referenced this pull request Jan 20, 2024
@gdhuper
Added pub sub example (dapr#20)
c703233 
* Added appcall proto and server implemenation

* added wrapper for appcallback

* WIP: working pubsub example

* added publisher code, some code cleanup

* fixed README typo

* code clean up, added comments

* resolved PR comments

* update README

* replaced thread::sleep with tokio::delay_for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev left review comments

@youngbupark youngbupark youngbupark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pubsub example
3 participants
@gdhuper @rylev @youngbupark