-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate cargo crate publish process #34
Conversation
@youngbupark is there a versioning scheme that you follow for sdk versions? |
"0.1.0-alpha.2" is the last published version. /cc @yaron2 @msfussell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! I left small comment.
.github/workflows/ci.yml
Outdated
name: Publish | ||
runs-on: ubuntu-latest | ||
needs: [lint, build] | ||
if: github.event_name == 'push' && github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would publish the cargo package only for tag push. Please see the below command:
So the release process (v0.2.0-alpha.0) will be
- create release-* branch
- push v* tag with v0.2.0-alpha.0
Please change this workflow to publish cargo package when it is version tag push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. This workflow makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gdhuper any updates ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for delay. Will try to wrap this up end of today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
* Added package metadata to cargo.toml * Added license info: * Testing rust ci * Fixed ci event to push, pull_request * Testing publish dry run * Added lint and publish steps * test push * testing publish with dry run * changed version to match other sdks * updated README, added build badges * bump crate version * update readme * fixed typo * added push tag condition for crate publish :
Description
Issue reference
This PR will close: #33
Checklist