Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate cargo crate publish process #34

Merged
merged 14 commits into from
Dec 15, 2020

Conversation

gdhuper
Copy link
Member

@gdhuper gdhuper commented Nov 27, 2020

Description

  • Added CI pipeline to automate cargo crate publish on crates.io
  • Updated README with instructions on how to use published crate

Issue reference

This PR will close: #33

Checklist

  • Code compiles correctly
  • Extended the documentation
  • Crate Versioning Scheme
  • Update github-actions url for README build badge

Cargo.toml Outdated Show resolved Hide resolved
@gdhuper
Copy link
Member Author

gdhuper commented Dec 1, 2020

@youngbupark is there a versioning scheme that you follow for sdk versions?

@youngbupark
Copy link
Contributor

@youngbupark is there a versioning scheme that you follow for sdk versions?

https://crates.io/crates/dapr

"0.1.0-alpha.2" is the last published version. 0.2.0-alpha.0 makes sense for this release.

/cc @yaron2 @msfussell

@gdhuper gdhuper marked this pull request as ready for review December 2, 2020 09:20
Copy link
Contributor

@youngbupark youngbupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I left small comment.

name: Publish
runs-on: ubuntu-latest
needs: [lint, build]
if: github.event_name == 'push' && github.ref == 'refs/heads/master'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would publish the cargo package only for tag push. Please see the below command:

https://github.com/dapr/cli/blob/51bbd0a1715eb00a2cc6e3dd2518a42336418389/.github/workflows/dapr_cli.yaml#L89

So the release process (v0.2.0-alpha.0) will be

  1. create release-* branch
  2. push v* tag with v0.2.0-alpha.0

Please change this workflow to publish cargo package when it is version tag push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. This workflow makes more sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdhuper any updates ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for delay. Will try to wrap this up end of today.

Copy link
Contributor

@youngbupark youngbupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@youngbupark youngbupark merged commit e764932 into dapr:master Dec 15, 2020
cscetbon pushed a commit to cscetbon/rust-sdk that referenced this pull request Jan 20, 2024
* Added package metadata to cargo.toml

* Added license info:

* Testing rust ci

* Fixed ci event to push, pull_request

* Testing publish dry run

* Added lint and publish steps

* test push

* testing publish with dry run

* changed version to match other sdks

* updated README, added build badges

* bump crate version

* update readme

* fixed typo

* added push tag condition for crate publish
:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate cargo package publish process
3 participants