-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TGA, BMP and PSD readers. Added TGA and BMP writers. #100
Conversation
They are very light as they rely on two auxiliary .h files (stb_image.h and stb_image_writer.h).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an interesting addition, though to be honest I was hoping to leave some of the older formats like TGA behind (DJV has TGA support which I did not port over to tlRender). On the other hand it's not a huge amount of code which is good.
My main concern would be if STB handles reading images from memory? That's necessary for the .otioz support which is essential. Also tests would need to be added similar to the other image formats in "tests\tlIOTest".
Adding these formats also brings up the question of whether to use OpenImageIO instead. That project was recently adopted by ASWF and aligns with the other dependencies like OpenColorIO and OpenTimelineIO. It has support for TGA and BMP, and also others like SGI which would actually remove code from tlRender which would be great.
Added reading from memory.
Updated to darby/main.
It does handle images from memory. I added code for it now, but I didn't know how to test it. I also added a STBTest.cpp/.h based on the SGITest but also didn't know how to test it. Can you test them and see if they are okay? |
You can run the tests like:
To test reading from memory you can use an .otioz file. However the "otioconvert" utility doesn't support image sequences yet, but I have a PR to fix that: |
Thanks! |
They are very light as they rely on two auxiliary .h files (stb_image.h and stb_image_writer.h).