-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanity url doesn't redirect to github repo #245
Comments
A related issue: github.com/imdario/mergo@v1.0.0 was "published", but it is broken because it is actually dario.cat/mergo@v1.0.0. When it goes to compile, the Go tool notices the mismatch between the module name and the URL and stops compilation, but it still picks up github.com/imdario/mergo@v1.0.0 during the Go module resolution time, unfortunately. What should happen instead is that the dario.cat/mergo releases should be separate from the old github.com/imdario/mergo releases. Ideally, github.com/imdario/mergo@v1.0.1 would be published with a retraction of github.com/imdario/mergo@v1.0.0 and itself github.com/imdario/mergo@v1.0.1. In any event, as a workaround, I have added |
@carlmjohnson I'm not sure how the retraction would work. Would everybody have to revert to the github.com URL? Keep in mind that I made this change to also switch my GitHub username. |
Because any version you tag ends up being available at both the old and new repo addresses, I'm not sure that there's any way to fix it. It would need to be published at just the old repo address but not the new one, and I'm not sure there's any way to do that. |
Just saw this during our project update, is this just a warning?
|
@carlmjohnson After some consideration, I won't release a retraction. I think the best way forward is - when mergo isn't a direct dependency in your project - to recommend using replace instead:
@lzap You can fix that error using the replace directive or upgrading mergo if it's used directly in your code, just replacing the import URL to the one shown in your error. The reason behind the decision is that Mergo is stable, with some quirks and improvements, but it's reasonable complete. So, I won't be adding new features, nor fixes as it works for lots of use cases. No new versions should pop up after v1.0.0. PS: I updated my vanity URL to redirect to the docs, not the github repo cc @andig |
Discussed in #244. It would be nice to do so to improve discoverability of this repo.
The text was updated successfully, but these errors were encountered: