Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec 2.14.3 QoS a little bit abstract? #32

Closed
seanzw opened this issue Jun 1, 2020 · 4 comments
Closed

Sec 2.14.3 QoS a little bit abstract? #32

seanzw opened this issue Jun 1, 2020 · 4 comments

Comments

@seanzw
Copy link

seanzw commented Jun 1, 2020

I feel this section is a little abstract and not that closely related to gem5. It would be great if it can cover more about the implementation in gem5 and what new research questions it empowers gem5 to explore?

@giactra
Copy link
Contributor

giactra commented Jun 1, 2020

Hi,
If you check the original draft we sent to Jason, there is a gem5 part which hasn't been added to the paper as far as I can see:

https://docs.google.com/document/d/1GRrNeFXO2IqimuxYmkODkLxssWb6-oUcXVvj8VbCoB8/edit#heading=h.iq0papa79ac

"My contribution involved the definition of a QoS-aware memory controller in gem5, and the definition of basic (example) policies modelling the prioritization algorithm of the memory controller. Those are the Fixed priority policy (every master in the system has a fixed priority assigned) and the Proportional Fair policy (where the priority of a master is dynamically adjusted at runtime based on utilization).
I have rewritten the DRAM controller in gem5 to include the QoS changes; with the framework in place a user can write its own policy and seamlessly plug it into a real memory controller model to unlock system wide explorations under its own arbitration algorithm."

@seanzw
Copy link
Author

seanzw commented Jun 1, 2020

Thanks! I think including this in the maker will make it more complete.

giactra added a commit to giactra/gem5-20-paper that referenced this issue Jun 2, 2020
As reported by darchr#32 The QoS
entry was missing the details of how QoS had been implemented in gem5

Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
@giactra
Copy link
Contributor

giactra commented Jun 2, 2020

The PR has been merged, feel free to close the issue

@powerjg
Copy link
Member

powerjg commented Jun 2, 2020

Thanks everyone!

@powerjg powerjg closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants