Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List duplicate links in the report #8

Closed
darekkay opened this issue May 2, 2020 · 2 comments · Fixed by #18
Closed

List duplicate links in the report #8

darekkay opened this issue May 2, 2020 · 2 comments · Fixed by #18
Assignees
@jflip
Labels
good first issue Good for newcomers Type: Enhancement New feature or request

Comments

@darekkay
Copy link
Owner

darekkay commented May 2, 2020

The report command introduced in 2.1.0 returns the total number of links. This command should be improved to also find and list all duplicate links. There might be valid use cases for having duplicate links, so there should be a flag to disable this feature within report command (e.g. --no-duplicates).
@darekkay darekkay added Type: Enhancement New feature or request good first issue Good for newcomers labels May 2, 2020
@jflip
Copy link
Contributor

jflip commented Oct 1, 2020

Hey @darekkay mind if I give this a go? Still fairly fresh to open source but would like to support if I can

@darekkay
Copy link
Owner Author

darekkay commented Oct 1, 2020

Hey John, sure! Let me know if there's any support you require to get started 🚀

jflip added a commit to jflip/static-marks that referenced this issue Oct 6, 2020
@jflip
Implements darekkay#8
68bd13c 
My first implementation of duplcicate link checking
@darekkay darekkay mentioned this issue Oct 7, 2020
Merged
darekkay pushed a commit that referenced this issue Oct 7, 2020
@jflip
List duplicate links in the report (#8)
6ab92a8 
Fixes: #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jflip jflip

Labels
good first issue Good for newcomers Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements #8 jflip/static-marks
2 participants
@darekkay @jflip