-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity and object use the same ID #1
Comments
Thanks, I've opened a PR that fixes the guids. For the dereferenceable URIs, what should be served? Just the objects themselves? If someone goes to the Note id uri, will they just get the Note sub-object, and if someone goes to the Create id uri, they get served the Create object with the note sub-object? Can I leave out dereferencing the Create and just dereference the Note? |
for the Note's ID, you MUST ( |
@puckipedia I think the commit I just added addresses your concern. For example, if I send a Note with the {
"id": "https://2914e630.ngrok.io/m/78c20ffafb39e7fedf91e0916d6ed893",
"type": "Note",
"published": "2018-09-25T03:06:47.111Z",
"attributedTo": "https://2914e630.ngrok.io/u/tester",
"content": "Just testing this, please ignore.",
"to": "https://www.w3.org/ns/activitystreams#Public"
} This goes for both Create and Note objects. However, it doesn't address the boost issue, at least on Mastodon (if I boost this status from an account X on SERVER1, I can't see the boost from account Y on SERVER2 even though I follow X@SERVER1). |
Closed in #2. |
When sending a message to a remote server, the ID used for the Create and the Note are equivalent. This is invalid, according to the spec, and will cause multiple servers to refuse it. (also it isn't dereferencable, which will cause issues if someone boosts the note, the servers where noone follows the bot will just not show the boost)
The text was updated successfully, but these errors were encountered: