Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity and object use the same ID #1

Closed
puckipedia opened this issue Sep 15, 2018 · 4 comments
Closed

Activity and object use the same ID #1

puckipedia opened this issue Sep 15, 2018 · 4 comments
Assignees
Labels
bug Something isn't working spec AP spec issues

Comments

@puckipedia
Copy link

When sending a message to a remote server, the ID used for the Create and the Note are equivalent. This is invalid, according to the spec, and will cause multiple servers to refuse it. (also it isn't dereferencable, which will cause issues if someone boosts the note, the servers where noone follows the bot will just not show the boost)

@dariusk
Copy link
Owner

dariusk commented Sep 15, 2018

Thanks, I've opened a PR that fixes the guids.

For the dereferenceable URIs, what should be served? Just the objects themselves? If someone goes to the Note id uri, will they just get the Note sub-object, and if someone goes to the Create id uri, they get served the Create object with the note sub-object?

Can I leave out dereferencing the Create and just dereference the Note?

@dariusk dariusk self-assigned this Sep 15, 2018
@dariusk dariusk added bug Something isn't working spec AP spec issues labels Sep 15, 2018
@puckipedia
Copy link
Author

for the Note's ID, you MUST (RFC2119) serve the Note, and for the Create, you MAY return the Create with the Note inside, or just the Create.

dariusk added a commit that referenced this issue Sep 25, 2018
@dariusk
Copy link
Owner

dariusk commented Sep 25, 2018

@puckipedia I think the commit I just added addresses your concern. For example, if I send a Note with the id of https://2914e630.ngrok.io/m/78c20ffafb39e7fedf91e0916d6ed893, if you make a GET request to the URL with your browser you get the following JSON object (that URL won't work because I'm testing using a temporary domain):

{
"id": "https://2914e630.ngrok.io/m/78c20ffafb39e7fedf91e0916d6ed893",
"type": "Note",
"published": "2018-09-25T03:06:47.111Z",
"attributedTo": "https://2914e630.ngrok.io/u/tester",
"content": "Just testing this, please ignore.",
"to": "https://www.w3.org/ns/activitystreams#Public"
}

This goes for both Create and Note objects. However, it doesn't address the boost issue, at least on Mastodon (if I boost this status from an account X on SERVER1, I can't see the boost from account Y on SERVER2 even though I follow X@SERVER1).

@dariusk
Copy link
Owner

dariusk commented Mar 26, 2019

Closed in #2.

@dariusk dariusk closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec AP spec issues
Projects
None yet
Development

No branches or pull requests

2 participants