Consider response code 403 as an error #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PagerDuty sends a 403 - Forbidden response code when the service key is being rate-limited. The correct thing to do is to retry the request after a delay - so treat this condition as if it were any other error.
|
Old PR, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PagerDuty sends a 403 - Forbidden response code when the service key is
being rate-limited. The correct thing to do is to retry the request
after a delay - so treat this condition as if it were any other error.
Includes test of this behavior against a test server that only returns 403.
See PagerDuty event v1 documentation for these details and recommendations.