-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detail on my changeset #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on content-length
free(NULL) is legal almost everywhere (embedded?), the only reason to have free_null macro is to nullify pointer after freeing. |
Thank you! I've merged your changes - I've not deeply reviewed http-related code as I left it in half-broken state years ago, so I assume that at least it works for you now. :-) |
cappiewu
pushed a commit
to cappiewu/redsocks
that referenced
this pull request
Jan 14, 2016
update from origin
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feel free to comment on my patch
It's the reason I forked this project. unlike socks5 or http basic auth, http digest auth is a challenge-response type. After receiving an 403 status response containing an auth challenge, we calculate a new response and reconnect to proxy server.
To be effective, I add a http_auth structure for each http proxy instance(not client), so in most case, only first client connection require two relay connections for each instance.
I added base64.c for basic scheme and md5.c for digest scheme, along with a rfc document.
there is a FIXME in redsocks.c:redsocks_onenter(), I can't calloc exact memory for an instance before parsing the config file.
the only changes I'm not quite sure is that: clang didn't support variable-length array in an union, so I reimplement two blocks of code in socks4/5.c using calloc.