Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail on my changeset #1

Merged
28 commits merged into from
Jan 15, 2011
Merged

detail on my changeset #1

28 commits merged into from
Jan 15, 2011

Conversation

bjin
Copy link
Contributor

@bjin bjin commented Dec 3, 2010

feel free to comment on my patch

  • proxy auth (basic/digest scheme) for http-connect/http-relay
    It's the reason I forked this project. unlike socks5 or http basic auth, http digest auth is a challenge-response type. After receiving an 403 status response containing an auth challenge, we calculate a new response and reconnect to proxy server.
    To be effective, I add a http_auth structure for each http proxy instance(not client), so in most case, only first client connection require two relay connections for each instance.
    I added base64.c for basic scheme and md5.c for digest scheme, along with a rfc document.
    there is a FIXME in redsocks.c:redsocks_onenter(), I can't calloc exact memory for an instance before parsing the config file.
  • some code cleanup, add support for clang, clean warnings
    the only changes I'm not quite sure is that: clang didn't support variable-length array in an union, so I reimplement two blocks of code in socks4/5.c using calloc.
  • add -p command line option, which is useful for daemon scripts

@darkk
Copy link
Owner

darkk commented Jan 12, 2011

free(NULL) is legal almost everywhere (embedded?), the only reason to have free_null macro is to nullify pointer after freeing.

@darkk
Copy link
Owner

darkk commented Jan 15, 2011

Thank you! I've merged your changes - I've not deeply reviewed http-related code as I left it in half-broken state years ago, so I assume that at least it works for you now. :-)

cappiewu pushed a commit to cappiewu/redsocks that referenced this pull request Jan 14, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants