Make sure to run accept_enable
when handling accept_backoff_ev
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #99.
There's a situation where the connection pressure is solved but redsocks doesn't resume listening to new connections.
redsocks_conn_max
is hit,conn_pressure
runs.conn_pressure
adds theaccept_backoff_ev
event and disables all listeners.accept_backoff_ev
gets triggered andredsocks_accept_backoff
gets called.conn_pressure_ongoing() == true
, soconn_pressure
runs.conn_pressure
drops it and returns.conn_pressure_ongoing() == false
, butaccept_enable
isn't called because the conditional was evaluated before runningconn_pressure
.redsocks_accept_backoff
returns, soaccept_backoff_ev
is not pending anymore andaccept_enable
will never be called.