/redsocks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redsocks_evbuffer_readline with libevent 2.1 #123

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@apoikos @houtmanj @agherzan
@apoikos
Contributor

apoikos commented Mar 29, 2018

_EVENT_NUMERIC_VERSION was renamed to EVENT__NUMERIC_VERSION in libevent
2.1. As a result, redsocks_evbuffer_readline would end up using
evbuffer_readline(buf), which causes client connections to hang
indefinitely.

Switch the check to using LIBEVENT_VERSION_NUMBER instead.
LIBEVENT_VERSION_NUMBER has been around since libevent 2.0.3 and
redsocks is already using it in other parts of the code.

Fixes #107, #122.
@apoikos
Fix redsocks_evbuffer_readline with libevent 2.1 
_EVENT_NUMERIC_VERSION was renamed to EVENT__NUMERIC_VERSION in libevent
2.1. As a result, redsocks_evbuffer_readline would end up using
evbuffer_readline(buf), which causes client connections to hang
indefinitely.

Switch the check to using LIBEVENT_VERSION_NUMBER instead.
LIBEVENT_VERSION_NUMBER has been around since libevent 2.0.3 and
redsocks is already using it in other parts of the code.

Fixes #107, #122.
792a06b

imrehg added a commit to resin-os/meta-resin that referenced this pull request Apr 2, 2018

@imrehg
redsocks: patch to be able to use libevent 2.1.x 
Current version of redsocks cannot use libevent 2.1.x because of a breaking
change, and that results in the `http-connect` (and possibly other)
opreation is broken.

This commit pulls in a proposed patch from redsocks:
darkk/redsocks#123

Change-type: patch
Changelog-entry: Apply upstream patch for redsocks to fix http-config regression
Signed-off-by: Gergely Imreh <imrehg@gmail.com>
Verified
This commit was signed with a verified signature.
@imrehg imrehg Gergely Imreh
GPG key ID: 2159E9E41D38A9EB Learn about signing commits
48c9154

imrehg added a commit to resin-os/meta-resin that referenced this pull request Apr 2, 2018

@imrehg
redsocks: patch to be able to use libevent 2.1.x 
Current version of redsocks cannot use libevent 2.1.x because of a breaking
change, and that results in the `http-connect` (and possibly other)
operation being broken (regression since meta-resin 2.10.0)

This commit pulls in a proposed patch from redsocks:
darkk/redsocks#123

Change-type: patch
Changelog-entry: Apply upstream patch for redsocks to fix http-config regression
Signed-off-by: Gergely Imreh <imrehg@gmail.com>
Verified
This commit was signed with a verified signature.
@imrehg imrehg Gergely Imreh
GPG key ID: 2159E9E41D38A9EB Learn about signing commits
Loading status checks…
a73b566

@imrehg imrehg referenced this pull request Apr 2, 2018

Merged

redsocks: patch to be able to use libevent 2.1.x #1049

3 of 4 tasks complete

agherzan added a commit to resin-os/meta-resin that referenced this pull request Apr 3, 2018

@imrehg @agherzan
redsocks: patch to be able to use libevent 2.1.x 
Current version of redsocks cannot use libevent 2.1.x because of a breaking
change, and that results in the `http-connect` (and possibly other)
operation being broken (regression since meta-resin 2.10.0)

This commit pulls in a proposed patch from redsocks:
darkk/redsocks#123

Change-type: patch
Changelog-entry: Apply upstream patch for redsocks to fix http-config regression
Signed-off-by: Gergely Imreh <imrehg@gmail.com>
396c2a8
@houtmanj

This comment has been minimized.

Show comment
Hide comment
@houtmanj

houtmanj Apr 13, 2018

This change fixed my issue on archlinux with redsocks and libevent 2.1. Works like a charm now

houtmanj commented Apr 13, 2018

This change fixed my issue on archlinux with redsocks and libevent 2.1. Works like a charm now
@agherzan

This comment has been minimized.

Show comment
Hide comment
@agherzan

agherzan Apr 17, 2018

Any chance we can get this in soon?

agherzan commented Apr 17, 2018

Any chance we can get this in soon?

@agherzan agherzan referenced this pull request Apr 17, 2018

Closed

libevent2 support #94

Zrubi added a commit to Zrubi/redsocks that referenced this pull request Jun 14, 2018

@Zrubi
Fix redsocks_evbuffer_readline with libevent 2.1 darkk#123
918ab10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment